Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vertical_parameter_alignment_on_call more flexible with multiline literal #1646

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Make vertical_parameter_alignment_on_call more flexible with multiline literal #1646

merged 1 commit into from
Jul 1, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1643

@SwiftLintBot
Copy link

173 Messages
📖 Linting Aerial with this PR took 0.39s vs 0.33s on master (18% slower)
📖 Linting Alamofire with this PR took 2.58s vs 2.53s on master (1% slower)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L850:33: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Widgets/InnerStrokedView.swift#L44:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Firefox with this PR took 10.65s vs 10.82s on master (1% faster)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/ViewModels/AppDelegateViewModel.swift#L937:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/DiscoveryPageViewControllerTests.swift#L55:55: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/FindFriendsViewControllerTests.swift#L62:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Views/Controllers/ResetPasswordViewController.swift#L57:15: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/Format.swift#L226:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivityFriendFollowCellViewModel.swift#L42:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivityFriendBackingViewModel.swift#L165:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivityProjectStatusViewModel.swift#L151:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivitiesViewModelTests.swift#L448:35: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivitiesViewModelTests.swift#L454:35: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ActivityUpdateViewModelTests.swift#L70:8: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/BackingCellViewModelTests.swift#L40:11: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/BackingViewModelTests.swift#L153:40: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/BackingViewModelTests.swift#L361:42: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardRewardsCellViewModelTests.swift#L142:8: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardRewardsCellViewModelTests.swift#L168:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardRewardsCellViewModelTests.swift#L177:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardRewardsCellViewModelTests.swift#L187:5: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardVideoCellViewModelTests.swift#L62:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardVideoCellViewModelTests.swift#L69:10: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L74:28: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L81:55: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L108:56: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L129:37: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L139:64: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L161:37: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L172:64: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L184:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L384:30: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L387:64: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L393:52: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L398:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L409:72: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DashboardViewModelTests.swift#L416:65: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryFiltersViewModelTests.swift#L106:71: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPostcardViewModelTests.swift#L135:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPostcardViewModelTests.swift#L143:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPostcardViewModelTests.swift#L154:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPostcardViewModelTests.swift#L166:12: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPageViewModelTests.swift#L283:37: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/DiscoveryPageViewModelTests.swift#L300:67: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FacebookConfirmationViewModelTests.swift#L119:21: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L124:76: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L127:7: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L177:78: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L231:78: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L287:78: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFaceookConnectCellViewModelTests.swift#L341:78: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L134:76: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L136:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L158:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L217:7: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L219:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L231:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModelTests.swift#L246:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L51:66: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L62:66: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L75:66: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L80:46: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L229:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L233:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L244:74: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsViewModelTests.swift#L249:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/HelpViewModelTests.swift#L63:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/HelpViewModelTests.swift#L76:56: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/HelpViewModelTests.swift#L110:76: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/HelpViewModelTests.swift#L134:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LiveStreamContainerViewModelTests.swift#L606:57: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginViewModelTests.swift#L214:31: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginToutViewModelTests.swift#L173:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginToutViewModelTests.swift#L197:25: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginToutViewModelTests.swift#L238:27: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginToutViewModelTests.swift#L278:27: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/LoginToutViewModelTests.swift#L318:27: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ProfileViewModelTests.swift#L113:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ProjectNotificationCellViewModelTests.swift#L68:41: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ProjectNavigatorViewModelTests.swift#L378:60: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ResetPasswordViewModelTests.swift#L109:36: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardCellViewModelTests.swift#L347:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SearchProjectCellViewModel.swift#L44:9: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsViewModelTests.swift#L240:40: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsViewModelTests.swift#L277:38: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsViewModelTests.swift#L301:54: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsViewModelTests.swift#L340:7: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SettingsViewModelTests.swift#L350:70: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/SignupViewModelTests.swift#L159:51: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L96:21: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L115:21: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L143:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L167:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L191:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L215:49: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L238:77: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L260:77: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L282:77: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/TwoFactorViewModelTests.swift#L304:77: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L586:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L591:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L639:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L644:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L694:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/RewardPledgeViewModelTests.swift#L699:13: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/ThanksViewModelTests.swift#L93:61: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/VideoViewModelTests.swift#L118:32: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/VideoViewModelTests.swift#L215:69: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/VideoViewModelTests.swift#L220:71: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/VideoViewModelTests.swift#L226:75: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/VideoViewModelTests.swift#L272:71: warning: Vertical Parameter Alignment On Call Violation: Function parameters should be aligned vertically if they’re in multiple lines in a method call. (vertical_parameter_alignment_on_call)
📖 Linting Kickstarter with this PR took 15.72s vs 16.28s on master (3% faster)
📖 Linting Moya with this PR took 0.68s vs 0.81s on master (16% faster)
⚠️ Danger found 173 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 115.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1646 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
- Coverage   88.08%   88.07%   -0.02%     
==========================================
  Files         196      196              
  Lines        9838     9829       -9     
==========================================
- Hits         8666     8657       -9     
  Misses       1172     1172
Impacted Files Coverage Δ
...k/Rules/VerticalParameterAlignmentOnCallRule.swift 96.66% <88.88%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c02020...7ec710e. Read the comment docs.

@marcelofabri marcelofabri merged commit 5ce67cb into master Jul 1, 2017
@marcelofabri marcelofabri deleted the bugfix-1643 branch July 1, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelofabri @SwiftLintBot @codecov-io